Repository navigation
Publish wheels using older aarch64 images - #158
rhpvorderman wants to merge 10 commits into
Conversation
|
The "Release x86 platforms only" commit here seems to be the reason why the recent 1.5.2 release of isal doesn't include aarch64 wheels. Since the 1.5.1 release did include those wheels, are there plans to restore them for 1.5.2? Or will they not be provided any more going forward? |
|
@tsibley There is an issue with cibuildwheel on github actions. It somehow causes a segmentation fault when the wheel is tested. I am not going to provide faulty wheels, and I have already spent more time debugging the issue than I can justify. I don't use any aarch64 hardware at work. So if the wheels magically start passing tests again they will be published, if not I will let it be. If you are in the position to actually test why those wheels are corrupted you are welcome to make a PR to fix the issue. |
|
@rhpvorderman Thanks for your response. I appreciate not providing faulty wheels and your debugging efforts. It sounds like we should arrange for isal aarch64 builds ourselves in our system instead of relying on pre-built wheels. I'm not sure if we'll be in a position to figure out the issue with isal's CI builds, but if we are of course we'll contribute back.
Hmm. This is somewhat outside the area of my expertise, but it seems to me that libasan was not in effect for those tests? I see this in the workflow job logs: immediately before the second |
|
The libasan path being preloaded is not a shared library: Looks like some sort of "library by reference" meant to be processed by ld? Ah, yes, from |
That segfault is the cause of the gzip compliance testing running python without PYTHONMALLOC=malloc, which causes the libasan crashes. This is a known issue (for me). I am primarily interested in test_zlib_compliance, which crashes when the wheels are built.
Strange. As later it does crash on libasan errors. That seems to me as it is working correctly. Regardless, I think the error is not in the python-isal code. I think it has something to do with the build process that cibuildwheel uses. I have no idea to fix it. At this moment I hope it just disappears again at some point. |
|
Looks like the issue fixed itself! 1.5.3 is released with aarch64 images. |
Checklist
The most recent ones cause segmentation faults. This is a dummy PR to start the actions